Reset settings and fix for AppConfig.ready

[ar0ne]

---

name: Remove db calls from app ready hook
about: Submit a pull request for this project
assignees: fabiocaccamo

---

Describe your changes
First of all, Django "doesn't recommend" to run db calls in app ready hook (https://django.readthedocs.io/en/latest/ref/applications.html#django.apps.AppConfig.ready)

Instead, I'd like to explicitly ask users to set default values. For that they could use new dj-command:

python manage.py reset_extra_settings

Additionally, I added a button to "changelist" admin page.

Related issue
110
121

Checklist before requesting a review

• I have performed a self-review of my code.
• I have added tests for the proposed changes.
• I have run the tests and there are not errors.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.45%. Comparing base (fd891da) to head (7608c7e).
Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   85.51%   85.45%   -0.07%     
==========================================
  Files          21       21              
  Lines         435      433       -2     
==========================================
- Hits          372      370       -2     
  Misses         63       63              

Flag	Coverage Δ
unittests	85.45% <100.00%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fabiocaccamo]

@ar0ne thank you for this PR, could you please split it into two smaller PRs, one for the fix and the other one for the admin integration (this one with a separate test module)?

[fabiocaccamo]

@ar0ne if you're still interested in working on this PR, please rebase it.

[ar0ne]

@fabiocaccamo hi, sure i hope to find some time on the weekend to address you comments

[fabiocaccamo]

I'm pretty sure that running this command before migrate on first install will raise an Exception.

[fabiocaccamo]

Removing this line current tests fail.

[fabiocaccamo]

I think that these tests are not enough and they don't cover well real usage, I try to explain better what I mean:

• Tests pass because Setting.set_defaults_from_settings() is invoked manually (it should not)
• Setting.set_defaults_from_settings() should be called automatically at some point at the begininng, but now calling it on app ready is discouraged.
• Should improve the tests using more EXTRA_SETTINGS_DEFAULTS