Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat models. #68

Merged
merged 2 commits into from Feb 10, 2023
Merged

Reformat models. #68

merged 2 commits into from Feb 10, 2023

Conversation

zackkh
Copy link
Contributor

@zackkh zackkh commented Feb 10, 2023


name: Pull request
about: Submit a pull request for this project
title: 'Add validator to Setting instance if it exists in settings dict'
assignees: fabiocaccamo


Describe your changes
added line validator = item.get('validator', None) to extra_settings/models.py
and updated defaults of get_or_create

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 85.45% // Head: 85.48% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (7aa5d76) compared to base (7429768).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   85.45%   85.48%   +0.03%     
==========================================
  Files          21       21              
  Lines         433      434       +1     
==========================================
+ Hits          370      371       +1     
  Misses         63       63              
Flag Coverage Δ
unittests 85.48% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
extra_settings/models.py 99.30% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zackkh
Copy link
Contributor Author

zackkh commented Feb 10, 2023

@fabiocaccamo Sorry for the trouble, this is my first time working with actions

@fabiocaccamo
Copy link
Owner

@zackkh don't worry! Tests and actions help writing more robust code easily and preventing regressions.

Thank you for the fix, nice catch!

@fabiocaccamo fabiocaccamo merged commit 1b15d11 into fabiocaccamo:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants