Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ini format to support nested structures. #289

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

fabiocaccamo
Copy link
Owner


name: Pull request
about: Submit a pull request for this project
assignees: fabiocaccamo


Describe your changes
Allow ini format to support nested structures by encoding/decoding (json format) values that are collections (dict, list, set, tuple).

Related issue
Fix #284

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests for the proposed changes.
  • I have run the tests and there are not errors.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (9e07e48) 96.50% compared to head (332638d) 96.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   96.50%   96.52%   +0.02%     
==========================================
  Files          61       61              
  Lines        1832     1844      +12     
==========================================
+ Hits         1768     1780      +12     
  Misses         64       64              
Flag Coverage Δ
unittests 96.52% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
benedict/serializers/ini.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fabiocaccamo fabiocaccamo merged commit 84fa1c8 into main May 16, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_ini() returns a str instead of a dict
1 participant