Prevent temp file deletion on file close on Windows. #121

fabiocaccamo · May 16, 2024 · c5853f3 · c5853f3
1 parent 94fb619
commit c5853f3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/fsutil/__init__.py b/fsutil/__init__.py
@@ -1428,6 +1428,7 @@ def _write_file_atomic(
             mode=mode,
             dir=dirpath,
             delete=True,
+            delete_on_close=False,
             encoding=encoding,
         ) as file:
             file.write(content)

diff --git a/tests/test.py b/tests/test.py
@@ -1366,6 +1366,12 @@ def test_write_file_atomic(self):
         fsutil.write_file(path, content="Hello Jupiter", atomic=True)
         self.assertEqual(fsutil.read_file(path), "Hello Jupiter")
 
+    def test_write_file_atomic_no_temp_files_left(self):
+        path = self.temp_path("a/b/c.txt")
+        fsutil.write_file(path, content="Hello World", atomic=True)
+        fsutil.write_file(path, content="Hello Jupiter", atomic=True)
+        self.assertEqual(fsutil.list_files(self.temp_path("a/b/")), [path])
+
     @unittest.skipIf(sys.platform.startswith("win"), "Test skipped on Windows")
     def test_write_file_atomic_permissions_inheritance(self):
         path = self.temp_path("a/b/c.txt")