Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update angular version from 14 to 15 #111

Conversation

midhunadarvin
Copy link
Contributor

Description

  • update package.json dependencies
  • npm audit force fix

Steps Taken

  • ng update @angular/core@15 @angular/cli@15
  • address dependency conflicts and updates
  • add MatDialogModule to app module imports as it is required for TriggerListComponent ( had issue after updation )

Testing

  • Manual testing done on chrome Version 120.0.6099.234 (Official Build) (arm64)
  • Note : There are CSS changes required as the styles of inputs and MatDialog has changed. This PR does not address them, but updates the dependencies as part of tech debt addressal

Fixes #101

- update package.json dependencies
- npm audit force fix
- add `MatDialogModule` to app module imports
- mat-form-field has appearance property `outline` and `fill` now
- update unit tests
@fabioformosa fabioformosa changed the base branch from master to feature/#101_angular15_update February 2, 2024 23:06
Copy link

sonarcloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fabioformosa fabioformosa merged commit 1421c52 into fabioformosa:feature/#101_angular15_update Feb 2, 2024
2 checks passed
@fabioformosa
Copy link
Owner

Hi @midhunadarvin, I've parked the change in a feature branch and opened another PR #113
Some style regressions prevent to merge in the develop branch. Beyond those ones you mentioned, also some padding, fonts.
I leave the PR #113 opened.

@midhunadarvin midhunadarvin deleted the feat/angular-update branch February 3, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to angular 15
2 participants