Merge pull request #377 from fabiolb/issue-369-do-not-run-as-root

Issue #369: Do not allow to run fabio as root

config/config.go

@@ -16,6 +16,7 @@ type Config struct {
 	Runtime     Runtime
 	ProfileMode string
 	ProfilePath string
+	Insecure    bool
 }
 
 type CertSource struct {

config/load.go

@@ -116,6 +116,7 @@ func load(cmdline, environ, envprefix []string, props *properties.Properties) (c
 	var readTimeout, writeTimeout time.Duration
 	var gzipContentTypesValue string
 
+	f.BoolVar(&cfg.Insecure, "insecure", defaultConfig.Insecure, "allow fabio to run as root when set to true")
 	f.IntVar(&cfg.Proxy.MaxConn, "proxy.maxconn", defaultConfig.Proxy.MaxConn, "maximum number of cached connections")
 	f.StringVar(&cfg.Proxy.Strategy, "proxy.strategy", defaultConfig.Proxy.Strategy, "load balancing strategy")
 	f.StringVar(&cfg.Proxy.Matcher, "proxy.matcher", defaultConfig.Proxy.Matcher, "path matching algorithm")

config/load_test.go

@@ -49,6 +49,13 @@ func TestLoad(t *testing.T) {
 			desc: "default config",
 			cfg:  func(cfg *Config) *Config { return cfg },
 		},
+		{
+			args: []string{"-insecure=true"},
+			cfg: func(cfg *Config) *Config {
+				cfg.Insecure = true
+				return cfg
+			},
+		},
 		{
 			args: []string{"-profile.mode", "foo"},
 			cfg: func(cfg *Config) *Config {

main.go

@@ -71,6 +71,10 @@ func main() {
 	log.Printf("[INFO] Version %s starting", version)
 	log.Printf("[INFO] Go runtime is %s", runtime.Version())
 
+	// warn once so that it is at the beginning of the log
+	// this will also start the reminder go routine if necessary.
+	WarnIfRunAsRoot(cfg.Insecure)
+
 	// setup profiling if enabled
 	var prof interface {
 		Stop()
@@ -125,6 +129,10 @@ func main() {
 
 	// create proxies after metrics since they use the metrics registry.
 	startServers(cfg)
+
+	// warn again so that it is visible in the terminal
+	WarnIfRunAsRoot(cfg.Insecure)
+
 	exit.Wait()
 	log.Print("[INFO] Down")
 }

rootwarn_unix.go

@@ -0,0 +1,58 @@
+// +build !windows
+
+package main
+
+import (
+	"log"
+	"os"
+	"sync"
+	"time"
+)
+
+const interval = time.Hour
+
+const warnInsecure = `
+
+	************************************************************
+	You are running fabio as root with the '-insecure' flag
+	Please check https://fabiolb.net/faq/binding-to-low-ports/
+	for alternatives.
+	************************************************************
+
+`
+
+const warn17behavior = `
+
+	************************************************************
+	You are running fabio as root without the '-insecure' flag
+	This will stop working with fabio 1.7!
+	************************************************************
+
+`
+
+var once sync.Once
+
+func WarnIfRunAsRoot(allowRoot bool) {
+	isRoot := os.Getuid() == 0
+	if !isRoot {
+		return
+	}
+	doWarn(allowRoot)
+	once.Do(func() { go remind(allowRoot) })
+}
+
+func doWarn(allowRoot bool) {
+	warn := warnInsecure
+	if !allowRoot {
+		warn = warn17behavior
+	}
+	log.Printf("[INFO] Running fabio as UID=%d EUID=%d GID=%d", os.Getuid(), os.Geteuid(), os.Getgid())
+	log.Print("[WARN] ", warn)
+}
+
+func remind(allowRoot bool) {
+	for {
+		doWarn(allowRoot)
+		time.Sleep(interval)
+	}
+}

rootwarn_windows.go

@@ -0,0 +1,7 @@
+// +build windows
+
+package main
+
+func CheckInsecure(allowRoot bool) {
+	// windows not supported
+}