Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consul cert store URL with token not parsed correctly #172

Closed
magiconair opened this issue Oct 1, 2016 · 2 comments
Closed

Consul cert store URL with token not parsed correctly #172

magiconair opened this issue Oct 1, 2016 · 2 comments
Labels
bug
Milestone
1.3.3

Comments

@magiconair
Copy link
Contributor

When a URL for a consul certificate store contains a token then this token is not stripped off properly. Therefore, this URL does not work:

http://localhost:8500/v1/kv/path/to/cert?token=123
@magiconair magiconair added the bug label Oct 1, 2016
@magiconair magiconair mentioned this issue Oct 1, 2016
Closed
@magiconair magiconair changed the title Consul cert store does not work with token in URL Consul cert store URL with token not parsed correctly Oct 1, 2016
magiconair added a commit that referenced this issue Oct 1, 2016
@magiconair
Issue #172: Consul cert store URL with token not parsed correctly
0c739c0 
A consul certificate store is configured with a URL which points to a
key in the KV store which stores the certificates. This URL can be
secured with a consul auth token which is appended to the URL with
?token=xxx. When parsing the key name from the URL the token and other
parameters are not removed producing an invalid key in the KV store.
This patch fixes this and strips off the token and other parameters.
magiconair added a commit that referenced this issue Oct 1, 2016
@magiconair
Drop support for go1.6
a92ed3a 
The fix for #172 is using the subtest feature
from go1.7 which effectively drops support for
go1.6.
@cpredmann
Copy link

In testing, it looks like this now works; thanks for the fix

@magiconair
Copy link
Contributor Author

@cpredmann awesome. Thanks for testing. Closing.

@magiconair magiconair added this to the 1.3.3 milestone Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.3.3
Development

No branches or pull requests
2 participants
@magiconair @cpredmann