Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP+SNI proxy does not work with PROXY protocol #177

Closed
magiconair opened this issue Oct 12, 2016 · 0 comments
Closed

TCP+SNI proxy does not work with PROXY protocol #177

magiconair opened this issue Oct 12, 2016 · 0 comments
Labels
Milestone

Comments

@magiconair
Copy link
Contributor

magiconair commented Oct 12, 2016

The tcp+sni proxy does not work behind a router that uses the HAProxy PROXY protocol like the AWS ELB. This was first referred to in #1.

The reason is that the tcp+sni proxy does not filter out the PROXY preamble from the byte stream and the TLS code cannot decode a valid ClientHello message.

@magiconair magiconair added the bug label Oct 12, 2016
@magiconair magiconair added this to the 1.3.3 milestone Oct 12, 2016
magiconair added a commit that referenced this issue Oct 12, 2016
The TCP+SNI proxy fails when used behind a router which uses
the HAProxy PROXY protocol since it will not properly
decode the ClientHello message from the TLS handshake.

Adding the proxyproto listener support to the TCP listener
removes fixes this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant