Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoRouteHTMLPath not rendering HTML page #438

Closed
vincenthuynh opened this issue Feb 8, 2018 · 2 comments
Closed

NoRouteHTMLPath not rendering HTML page #438

vincenthuynh opened this issue Feb 8, 2018 · 2 comments
Milestone
1.5.8

Comments

@vincenthuynh
Copy link

vincenthuynh commented Feb 8, 2018 •
edited
Loading

Hi, is there any documentation on this feature and rendering the html page?
I have the following configured: registry.consul.noroutehtmlpath = /fabio/noroute2.html
I then put in a simple html page at the key but it would only show as plain-text on the non-routable url I hit.

How can I remove the # --- at the top of the page?

# --- fabio/noroute2.html
<!DOCTYPE html>
<html>
<body>
<p><b>fabio/noroute2.html</b></p>
</body>
</html>

Thanks!
Re: #56
@magiconair
Copy link
Contributor

Ah, I think this is a regression from #396. I'll fix this. For now please use 1.5.6

@vincenthuynh
Copy link
Author

Thanks for the feedback! Yes, reverting to v1.5.6 fixes this!

magiconair added a commit that referenced this issue Feb 11, 2018
@magiconair
Issue #438: Do not add separators for NoRouteHTML page
006c3d2 
This patch ensures that the NoRoute HTML page is returned
without additional separators as they are used for routing
table fragments.

This is a regression from 1.5.7.

Fixes #438
@magiconair magiconair mentioned this issue Feb 11, 2018
Merged
@magiconair magiconair added this to the 1.5.8 milestone Feb 11, 2018
magiconair added a commit that referenced this issue Feb 18, 2018
@magiconair
Merge pull request #441 from fabiolb/issue-438-noroutehtmlpath-has-se…
cc99a9b 
…parators

Issue #438: Do not add separators for NoRouteHTML page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.8
Development

No branches or pull requests
2 participants
@magiconair @vincenthuynh