Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong use function strings.HasPrefix() in file passsing.go #545

Closed
tpwow opened this issue Sep 10, 2018 · 1 comment
Closed

wrong use function strings.HasPrefix() in file passsing.go #545

tpwow opened this issue Sep 10, 2018 · 1 comment

Comments

@tpwow
Copy link

tpwow commented Sep 10, 2018

func isServiceCheck(c *api.HealthCheck) bool {
return c.ServiceID != "" &&
c.CheckID != "serfHealth" &&
c.CheckID != "_node_maintenance" &&
!strings.HasPrefix("_service_maintenance:", c.CheckID)
}

=======
strings.HasPrefix(c.CheckID, "_service_maintenance:")
@aaronhurt
Copy link
Member

Good catch. Want to submit a PR?

mfuterko added a commit to maytech/fabio that referenced this issue Mar 4, 2019
@mfuterko
Address fabiolb#545 - wrong use function strings.HasPrefix
ddd1a61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronhurt @tpwow