Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Add in idleTimeOut support for HTTP Server #634

Open
galen0624 opened this issue Apr 9, 2019 · 0 comments
Open

Enhancement - Add in idleTimeOut support for HTTP Server #634

galen0624 opened this issue Apr 9, 2019 · 0 comments

Comments

@galen0624
Copy link
Collaborator

Add in support for

// A Server defines parameters for running an HTTP server.
// The zero value for Server is a valid configuration.
type Server struct {
	// IdleTimeout is the maximum amount of time to wait for the
	// next request when keep-alives are enabled. If IdleTimeout
	// is zero, the value of ReadTimeout is used. If both are
	// zero, ReadHeaderTimeout is used.
	IdleTimeout time.Duration
}

Update the below struct and config to support idle time out

type Listen struct {
	Addr               string
	Proto              string
	ReadTimeout        time.Duration
	WriteTimeout       time.Duration
	CertSource         CertSource
	StrictMatch        bool
	TLSMinVersion      uint16
	TLSMaxVersion      uint16
	TLSCiphers         []uint16
	ProxyProto         bool
	ProxyHeaderTimeout time.Duration
}

We have an issue where applications that use text/event-stream (SSE) run into a read time out and the connection is dropped.

I will PR an update to add in idleTimeOut Support.

@galen0624 galen0624 changed the title Enhancement - Add in idleTimeout support for HTTP Server Enhancement - Add in idleTimeOut support for HTTP Server Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant