Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added idleTimout to config and to serve.go HTTP server #635

Merged
merged 3 commits into from
Jan 27, 2020

Conversation

galen0624
Copy link
Collaborator

@galen0624
Copy link
Collaborator Author

galen0624 commented Apr 9, 2019

I don't have access to codeship so I can't see what is broken in the testing. I can say that locally the tests I updated pass

 --- PASS: TestLoad/-proxy.addr_with_tls_configs (0.00s)
 --- PASS: TestLoad/-proxy.addr_with_named_tls_configs (0.00s)

@magiconair
Copy link
Contributor

Hmm, let me have a look.

@magiconair
Copy link
Contributor

Can you send me your email address to frank@magiconair.net? Then I'll invite you to the codeship project. We should put this on some other CI/CD platform IMO.

@magiconair
Copy link
Contributor

Damn, I think I've messed up the repo since I forgot to push the release changes from 1.5.11 and did a pull rebase. Do not pull changes right now until I've fixed this.

@aaronhurt
Copy link
Member

Can you send me your email address to frank@magiconair.net? Then I'll invite you to the codeship project. We should put this on some other CI/CD platform IMO.

I could setup a Travis build file.

@magiconair
Copy link
Contributor

yes, we could do that again. Last config was 3a04a7c

@magiconair
Copy link
Contributor

I think there was some issue with the verbose test logs being too long or so. Don't remember why I switched.

@magiconair
Copy link
Contributor

Ah right, tests on travis were highly volatile. Passing test was hit and miss. What about CircleCI?

@aaronhurt
Copy link
Member

Circle works for me. I'll give it a shot.

@magiconair
Copy link
Contributor

Re repo: damage is done but it isn't major. I've added a note to the Changelog regarding v1.5.11 release. Basically I forgot to push the last four commits after I did the release which only includes updates to more recent versions of consul and vault to test with. The release process itself wants two commits for changelog and main.go but I did that in one, reverted and fixed that. Sorry about that :(

@magiconair
Copy link
Contributor

magiconair commented Apr 9, 2019

@leprechau I've done a fair amount of CircleCI wrangling the last couple of weeks. See how far you get and I can pick up in the morning. ZZZ time here.

@magiconair
Copy link
Contributor

@galen0624 sorry for turning your PR into this CI/CD storm.

@galen0624
Copy link
Collaborator Author

No worries. We use drone https://github.com/drone/drone internally and it seems OK. Not great but its another option.

@magiconair
Copy link
Contributor

But we'd have to run that somewhere, right?

@galen0624
Copy link
Collaborator Author

yes so probably not the best option.

@galen0624
Copy link
Collaborator Author

Rebased with current Master

@aaronhurt
Copy link
Member

Triggering a rebuild with Travis.

@aaronhurt aaronhurt closed this Jan 27, 2020
@aaronhurt aaronhurt reopened this Jan 27, 2020
@aaronhurt aaronhurt merged commit 73c6eef into master Jan 27, 2020
@aaronhurt
Copy link
Member

@galen0624 Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants