New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuration via command line arguments #79

Closed

magiconair opened this issue Apr 9, 2016 · 0 comments

Labels

Milestone

Contributor

magiconair commented Apr 9, 2016

PR #63 spawned the discussion on supporting command line arguments in addition to environment variables. The suggested approach was to use github.com/spf13/viper also to reduce the amount of homegrown code.

The PR requires updates to two other projects which all have not been merged yet and adds three more libraries to the code. Also or because of this, the PR has been stale for a couple of weeks now. However, credit for the idea and the motivation belongs to @doublerebel.

I like the idea of supporting command line arguments and came up with an implementation that uses the flag.FlagSet from the Go standard library to achieve the same thing. All values can now be set either via command line, environment or properties. Environment variables are case insensitive and support an optional FABIO_ prefix. So both PROXY_ADDR and FABIO_PROXY_ADDR are valid but the FABIO_ prefixed values are preferred.

As an added bonus the github.com/magiconair/properties library was updated to 1.7.0 which now supports loading properties files from URLs.

The text was updated successfully, but these errors were encountered:

magiconair added the enhancement label

magiconair added a commit that referenced this issue


          Issue #79: Refactor config loading to use flag sets

eaf5408

* support cmdline, env vars and properties
* support env vars with and without a FABIO_ prefix
* support loading properties from URL

Inspired by PR #63 from @doublerebel

magiconair mentioned this issue

Viper config loader #63

Closed

magiconair added a commit that referenced this issue


          Issue #79: Refactor config loading to use flag sets

5c710e3

* support cmdline, env vars and properties
* support env vars with and without a FABIO_ prefix
* support loading properties from URL
* support consul agent on https

Inspired by PR #63 from @doublerebel

magiconair mentioned this issue

Refactor listener config #28

Closed

magiconair added a commit that referenced this issue


          Issue #79: Refactor config loading to use flag sets

90708db

* support cmdline, env vars and properties
* support env vars with and without a FABIO_ prefix
* support loading properties from URL
* support consul agent on https

Inspired by PR #63 from @doublerebel

magiconair added a commit that referenced this issue


          Issue #79: Refactor config loading to use flag sets

86e74c7

* support cmdline, env vars and properties
* support env vars with and without a FABIO_ prefix
* support loading properties from URL
* support consul agent on https

Inspired by PR #63 from @doublerebel

magiconair added a commit that referenced this issue


          Issue #79: Refactor config loading to use flag sets

7a74664

* support cmdline, env vars and properties
* support env vars with and without a FABIO_ prefix
* support loading properties from URL
* support consul agent on https

Inspired by PR #63 from @doublerebel

magiconair added a commit that referenced this issue


          Issue #79: Refactor config loading to use flag sets

e96914f

* support cmdline, env vars and properties
* support env vars with and without a FABIO_ prefix
* support loading properties from URL
* support consul agent on https

Inspired by PR #63 from @doublerebel

magiconair added a commit that referenced this issue


          Issue #79: Refactor config loading to use flag sets

d7f8633

* support cmdline, env vars and properties
* support env vars with and without a FABIO_ prefix
* support loading properties from URL
* support consul agent on https

Inspired by PR #63 from @doublerebel

magiconair added this to the 1.2 milestone

magiconair added a commit that referenced this issue


          Issue #79: Refactor config loading to use flag sets

01542f5

* support cmdline, env vars and properties
* support env vars with and without a FABIO_ prefix
* support loading properties from URL
* support consul agent on https

Inspired by PR #63 from @doublerebel

magiconair added a commit that referenced this issue


          Squash merge 1.2-release-branch

1d3d39f

* Issue #27: Add/remove certificates using API
* Issue #28: Refactor listener config
* Issue #70: SSL Certs from Vault
* Issue #79: Refactor config loading to use flag sets
* Issue #85: SNI Support

magiconair closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment