Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore fabio.exe #443

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Conversation

aaronhurt
Copy link
Member

add fabio.exe to the .gitignore and remove from the source tree

@magiconair magiconair merged commit 972fafe into fabiolb:master Feb 13, 2018
@kostyrev
Copy link

kostyrev commented Mar 5, 2018

Hi! I'd like to point out that though you've removed binary from the tree the binary is still there in history

$ git rev-list --all --objects | sed -n $(git rev-list --objects --all | cut -f1 -d' ' | git cat-file --batch-check | grep blob | sort -n -k 3 | tail -n1 | while read hash type size; do echo -n "-e s/$hash/$size/p "; done) | sort -n -k1
12059648 fabio.exe

and cloning this repo still takes 14M of space

$ du -s -h ../fabio/
14M	../fabio/

@magiconair
Copy link
Contributor

@kostyrev Thanks for reminding me.

However, the 14M is not just the .git directory but also the vendor folder, the docs and the rest of the code. The savings don't seem worth a force push to master.

$ git clone git@github.com:fabiolb/fabio fabio.clean
$ cd fabio.clean/
$ du -hs ../fabio.clean
 14M	../fabio.clean
$ du -hs .git
  8.7M	.git
$ git filter-branch --index-filter "git rm -rf --cached --ignore-unmatch fabio.exe" HEAD
$ rm -rf .git/refs/original/ && git reflog expire --all &&  git gc --aggressive --prune=now
$ du -hs .git
7.2M	.git
$ du -hs ../fabio.clean/
 13M	../fabio.clean/

@magiconair
Copy link
Contributor

magiconair commented Mar 6, 2018

@kostyrev FWIW, running git gc trimmed my .git directory down from 20M to 8.1M

@kostyrev
Copy link

kostyrev commented Mar 6, 2018

FYI: I used steps from github guide and get those results

$ du -sh ../fabio.clean
8.9M	../fabio.clean
$ du -sh ../fabio.master
14M	../fabio.master

@aaronhurt aaronhurt deleted the cleanup/ignore-fabio-exe branch January 22, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants