-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add $host pseudo variable #544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #533 |
2db510b
to
695ecb2
Compare
This adds support for $host, which behaves similarly to $path. The idea with this is to be able to create a global redirect of anything received on, say, http to the https equivalent of what you were trying to hit.
695ecb2
to
4086ae4
Compare
@holtwilkins looks good. Would you mind attaching a |
hey @leprechau it's failing a consul/vault test, not sure if that's normal or not
|
@holtwilkins yes, that's something that needs to be fixed. Tests with newer consul and vault are failing. Thanks for attaching though. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for $host, which behaves similarly to $path. The idea with this is to be able to create a global redirect of anything received on, say, http to the https equivalent of what you were trying to hit.