Correct the access control feature documentation page #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M S Vishwanath Bhat <msvbhat@gmail.com>
|
|
|
I got tripped by the doc page that when either of the source IP and XFF is matched, the rule will allowed. But in reality both of them should match the rule to be allowed. It took me sometime to go through the source code (and original PR) to find out. Hence updating the documentation page, so that other's don't have to spend time there :) |
aaronhurt
reviewed
Sep 12, 2018
|
Thank you, I can take the minor edits. |
|
@leprechau Thanks for reviewing and merging the PR. And apologies for late response. Was on holiday yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: M S Vishwanath Bhat msvbhat@gmail.com