Add GRPC proxy support #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magiconair
reviewed
Dec 7, 2018
proxy/grpc_handler.go
Outdated
| } | ||
|
|
||
| newCtx := context.Background() | ||
| conn, err := grpc.DialContext(newCtx, target.URL.Host, opts...) |
There was a problem hiding this comment.
Do you want to return conn even if there was an error?
|
Thanks a lot @andyroyle for this. Are you running this in prod already? |
|
@magiconair yeah we have this in production now for about 3 weeks - it was a replacement for us using HaProxy and it’s integrated well with consul :) |
|
Thx Paul. |
|
Is this the same as #436? |
|
So this PR doesn't include those http/2 changes from #436 in, because it creates an entirely separate transport. It might still be worth merging that. |
This was referenced Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds proper GRPC proxy support, including TLS upstream and TLS termination.