address concerns raised while troubleshooting #524

[aaronhurt]

This PR, when merged, should resolve #524 and restore proper TCP proxy functionality with an out-of-box configuration.

[aaronhurt]

@pschultz @magiconair PR to address #524

[magiconair]

Two minor nitpicks. Otherwise, LGTM.

[magiconair]

Is it possible to have multiple authors on a single commit? Then you could attribute @pschultz as well. More curious than asking.

[aaronhurt]

I'm not sure about the commit itself ... I don't know. I fully agree though that @pschultz should get credit in the changelog and release notes at a minimum.

[aaronhurt]

@magiconair Any more thoughts on changing the default state of proxy-protocol on the listener? Do we want to keep it false as-is in the current PR?

I also noticed that in the updated go-proxyproto package there is a function to check for allowed sources for proxy-protocol. That would elevate some of the security concerns but I think that's a later feature enhancement.

[magiconair]

@sean- would disabling PROXY by default affect you?

[aaronhurt]

@magiconair per earlier question...you definitely can with GitHub:
https://help.github.com/articles/creating-a-commit-with-multiple-authors/

[magiconair]

You'll learn something new every day. Thx for looking.

[sean-]

@magiconair, no it wouldn't. We're not using the TCP PROXY protocol anywhere. We're using gRPC now (successfully) and auth.

[magiconair]

Lets do this. Thank you all!

[magiconair]

@leprechau shoot, we forgot something. Can you provide another PR with an updated fabio.properties and documentation? Feel free to merge right away. I'll work on the CHANGELOG.

[aaronhurt]

@magiconair absolutely.

[magiconair]

Also, fabio users: if you find this change and think disabling PROXY by default was a grave mistake please let us know. Thx

[magiconair]

@leprechau does this disable proxy for tcp only or also for http?

[aaronhurt]

This disables PROXY protocol on all listeners by default unless enabled with pxyproto=true.

[magiconair]

I'm having second thoughts on disabling by default. Will sleep on it a night. :)

[aaronhurt]

Okay, I have the documentation done. I'll push it to a new branch and create a PR. For what it's worth HAProxy has it disabled by default unless specified on the listener as well.

[aaronhurt]

Updated documentation here: #583