Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy protocol on outbound tcp, tcp+sni and tcp with tls connection #598

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Proxy protocol on outbound tcp, tcp+sni and tcp with tls connection #598

merged 2 commits into from
Feb 26, 2019

Conversation

mfuterko
Copy link
Contributor

@mfuterko mfuterko commented Jan 29, 2019 •
edited by magiconair
Loading

Closes #191

@mfuterko mfuterko mentioned this pull request Jan 29, 2019
Open
@bkmit bkmit mentioned this pull request Feb 25, 2019
Closed
@magiconair magiconair added this to the 1.5.12 milestone Feb 25, 2019
aaronhurt
aaronhurt requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@aaronhurt aaronhurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor niggles. Overall great work and thank you!

proxy/tcp/proxy_proto.go Outdated Show resolved Hide resolved
proxy/tcp/tcptest/dialer.go Outdated Show resolved Hide resolved
proxy/tcp/tcptest/dialer.go Outdated Show resolved Hide resolved
@aaronhurt aaronhurt merged commit dd9ef7d into fabiolb:master Feb 26, 2019
@aaronhurt
Copy link
Member

Thank you!

@mfuterko
Copy link
Contributor Author

Hi! Thanks for the code review and merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronhurt aaronhurt aaronhurt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mfuterko @aaronhurt @magiconair