docs: fix layout without JS enabled #606
Merged
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bootstrap stylesheet for the website sets the header to position: fixed, taking it out of the layout flow. Some javascript later updates the style attribute, so that the content is pushed down by an appropriate amount. If JS is disabled that correction doesn't happen, and so the header overlaps the content. Make the header static by default, and only apply position: fixed if JavaScript is enabled. Fixes #599 Signed-off-by: Peter Schultz <peter.schultz@classmarkets.com>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bootstrap stylesheet for the website sets the header to
position: fixed, taking it out of the layout flow. Some javascript later updatesthe style attribute, so that the content is pushed down by an
appropriate amount.
If JS is disabled that correction doesn't happen, and so the header
overlaps the content.
Make the header static by default, and only apply
position: fixedifJavaScript is enabled.
Fixes #599