Issue 611 Added Custom API Driven Back end #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ices/fabio into issue-611-custom-backend
…ices/fabio into issue-611-custom-backend
|
|
|
@magiconair @leprechau Would either of you be able to grant me access to - continuous-integration/codeship ? I see that the builds are failing for our recent PRs and I would like to dig into why. I'm assuming its a go mod issue but I'll need access to confirm. Also please add @murphymj25 if possible. Thank you. |
Fix newBasicAuth function to pass the test
|
@galen0624 Commented in the issue. Thank you again! |
|
LGTM pending the one small change requested in #611 comment. |
…nto issue-611-custom-backend
|
#611 Updated CustomBE to Custom |
|
@galen0624 Thank you again. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#611