Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for profile/tracing #624

Merged
merged 2 commits into from
Jun 3, 2019
Merged

added support for profile/tracing #624

merged 2 commits into from
Jun 3, 2019

Conversation

galen0624
Copy link
Collaborator

@galen0624
Copy link
Collaborator Author

@magiconair @leprechau any chance I could be added to the codeship site to debug the build issues? I assume it's related to the go mod/sum. Below is a make test output that shows it working.
issue-623-make-test.txt

@mfuterko
Copy link
Contributor

Hi, @galen0624 can't this be a problem?

--- FAIL: TestLoadAuthSchemes (0.00s) --- FAIL: TestLoadAuthSchemes/should_fail_when_auth_scheme_fails_to_load (0.00s) auth_test.go:25: got stat /some/non/existent/file: no such file or directory, want open /some/non/existent/file: no such file or directory

If so please try merging my pull request (#617) into your branch to fix it.

@galen0624
Copy link
Collaborator Author

@mfuterko Thank you for the help!

Copy link
Contributor

@pires pires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this merged?

Copy link
Member

@pschultz pschultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@pschultz pschultz merged commit 22fa963 into master Jun 3, 2019
@magiconair magiconair added this to the 1.5.12 milestone Oct 11, 2019
@aaronhurt aaronhurt deleted the issue-623-add-tracing branch January 23, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants