Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle UI assets #643

Merged
merged 2 commits into from
May 6, 2019
Merged

Bundle UI assets #643

merged 2 commits into from
May 6, 2019

Conversation

pschultz
Copy link
Member

@pschultz pschultz commented Apr 16, 2019

Use statik to bundle UI assets, so the UI works without an Internet connection (#502) and with Browser privacy plugins (#642).

The updates to seemingly unrelated package checksums in go.mod are likely caused by vendoring with a Go version newer than 1.11.3 (see http://golang.org/issue/29278).

To update the assets in the future, change the URLs in admin/ui/generate.go, then run go generate ./admin/ui.

Closes #502.

The updates to seemingly unrelated package checksums in go.mod are
likely caused by vendoring with a Go version newer than 1.11.3
(see http://golang.org/issue/29278).

Signed-off-by: Peter Schultz <peter.schultz@classmarkets.com>
Use statik to bundle UI assets, so the UI works without an Internet
connection and with Browser privacy plugins.

Closes #502.

Signed-off-by: Peter Schultz <peter.schultz@classmarkets.com>
@aaronhurt aaronhurt merged commit 86dde1c into master May 6, 2019
@magiconair magiconair added this to the 1.5.12 milestone Oct 11, 2019
@aaronhurt aaronhurt deleted the 502-include-ui-assets branch January 23, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI broken where no internet access.
3 participants