Moved admin UI assets to use go embed #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove github.com/rakyll/statik dependency remove automatic calling of go generaate on every build / CI run. fix for setup-go@v3 in github actions vendor the admin ui assets, removing .gitignores that excluded them modify the ui generate to remove assets before downloading them.
nathanejohnson
force-pushed
the
feature/move_to_go_embed_for_static
branch
from
c296d52
to
c7f9e43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove github.com/rakyll/statik dependency
remove automatic calling of go generaate on every build / CI run.