Delegate enhancement #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `delegate` option is null|undefined, then `.on()` will ignore the `delegate` option and run the `callback` option on the node from which it was triggered. - Added tests. - Fixes fabiospampinato#56
Also in the tests lets make sure it's chainable. This should probably be propagated to all other tests to make sure each method is returning an instnace of cash() or not depending on the API.
shshaw
added a commit
to shshaw/cash
that referenced
this pull request
Mar 4, 2016
- Fix for issue fabiospampinato#57 with `null` delegates - Object can be passed as the first parameter for `on` to register multiple events at once - Better `ready` handling. - Don’t re-set node id if already set, and save cash node reference for better performance
Merged
Closed
|
A similar fix was implemented as of version 1.1.0. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #56 I've refactored the
.on()method to handle null/undefined delegates.The commit messages have specific detailas about the changes, and the tests have been updated to reflect.