Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon default in .deb package #90

Closed
lucasgray opened this issue Dec 28, 2018 · 10 comments
Closed

Icon default in .deb package #90

lucasgray opened this issue Dec 28, 2018 · 10 comments
Labels
bug Something isn't working help wanted Some help is needed and/or PRs are welcome
Milestone

Comments

@lucasgray
Copy link

Ubuntu 18.04.01 LTS

Installed via .deb, everything works perfectly but the icon did not show up - I modified /usr/share/applications/notable.desktop, specifically the line

Icon=/opt/Notable/resources/src/renderer/template/dist/images/icon.png

To add an icon from the installed resources. Previously the value notable only showed a default Ubuntu gears icon.

@fabiospampinato fabiospampinato added the bug Something isn't working label Dec 28, 2018
@fabiospampinato
Copy link
Member

I've noticed that as well, we are bundling the app with electron-builder, if anybody has any clue on how to configure it properly for this let me know.

@superhawk610
Copy link

Haven't had time to fork and test this out, but seems like icon.png may be the issue - see this thread.

@fabiospampinato
Copy link
Member

@superhawk610 thanks for the info, it seems the way to fix this is a bit laborious. If anyone would like to simply use the .ico version of the icon rather than the .png one for Linux builds and check if it works it would help me fix this faster.

@fabiospampinato fabiospampinato added the help wanted Some help is needed and/or PRs are welcome label Jan 3, 2019
@mikaelmello
Copy link
Contributor

+1.

Only that this time, on 1.1.0, /opt/Notable/resources/src/renderer/template/dist/images/icon.png does not exist. I had to download the icon and manually point it in the .desktop file

@fabiospampinato
Copy link
Member

fabiospampinato commented Jan 4, 2019

@mikaelmello The compiled "template" isn't bundled with the app, you have to generate it yourself (npm run svelto:dev).

@mikaelmello
Copy link
Contributor

Thanks for the info.

Anyway, I can't seem to get any icon to work with Notable. I've tried multiple three absolute paths and even went as far as setting Icon=code or Icon=google-chrome to see if anything worked.

Do you have any idea why?

By the way, great project once again, I've set it up on Windows (allowing edits on mobile via google-drive) and now I'm trying to make it work on Linux

@fabiospampinato
Copy link
Member

Do you have any idea why?

@mikaelmello not really, but @superhawk610 linked to this post which makes me think that maybe the .ico icon doesn't contain all the necessary sizes.

@tiotrom
Copy link

tiotrom commented Jan 23, 2019

Any progress on this? :) - No icon in Manjaro either and I kinda love the app thank you very much for making it!

@fabiospampinato
Copy link
Member

@tiotrom maybe it got fixed by #258, which will be included in the next release.

@fabiospampinato fabiospampinato added this to the Next milestone Jan 24, 2019
@fabiospampinato
Copy link
Member

Just tested this under Lubuntu and the problem is fixed for me, feel free to reopen the issue if the next release won't fix this for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Some help is needed and/or PRs are welcome
Development

No branches or pull requests

5 participants