fix linux appimage icons

[lianghongzhuo]

In Linux appimage, it generates icons at ~/.local/share/icons/hicolor/0x0/apps for my system.
This will let the system failed to show the app icon.
By creating a folder at ~/notable/resources/icon/icons the appimage will auto-generate all suitable size icons.

[fabiospampinato]

@lianghongzhuo do you know what this works? We are still only providing the png icon to the builder, it sounds like a problem that should be fixed upstream.

Also having icons inside icon is super weird, I'd avoid doing that. Does pointing to the icon directory work then?

[lianghongzhuo]

@fabiospampinato You are right, use icon folder directory also works.

[lianghongzhuo]

Here is the explain:

Linux icon set will be generated automatically based on the macOS icns file or common icon.png.

Or you can put them into the build/icons directory if you want to specify them yourself. The filename must contain the size (e.g. 32x32.png) of the icon). Recommended sizes: 16, 24, 32, 48, 64, 96, 128, 256 (or just 512).

[lianghongzhuo]

My guess is electron-builder only take build/icons as the default icon location setting. In this project, we use a custom folder which is resources/icon/. This may be the reason case this issue. So the way to solve is either speicify a folder contain icon.png in it. Or specify the file name with the size as the file name (eg: 32x32.png)

[fabiospampinato]

@lianghongzhuo awesome, thanks!

[mikaelmello]

Hopeful for this one, as the icon does not currently work for me

[fabiospampinato]

Thanks @lianghongzhuo, I've also mentioned the problem to electron-builder here electron-userland/electron-builder#3609