Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "lib" exlcusion #120

Closed
yani opened this issue Sep 7, 2018 · 4 comments
Closed

Add "lib" exlcusion #120

yani opened this issue Sep 7, 2018 · 4 comments

Comments

@yani
Copy link

yani commented Sep 7, 2018

It would be nice if "/lib/" folders are also exlcluded by default. The todo.embedded.exclude and todo.file.exclude take up a lot of space in the settings.json file.

@fabiospampinato
Copy link
Owner

I don't think /lib is an obvious exclusion, therefore it shouldn't be excluded by default. If you have a compelling argument on why this is actually the case I'll be happy to hear it.

There isn't lack of space in settings.json after all.

@yani
Copy link
Author

yani commented Sep 7, 2018

There isn't much lack, true. But when adding it I found it weird that all of the other directories came with it. I also thought it was a very common library directory name, I've been using it a lot for libraries that do not come from a package manager.

@fabiospampinato
Copy link
Owner

But when adding it I found it weird that all of the other directories came with it.

I found it weird to the first time it happened, but this is controlled by VSC, I can't fix that.

I've been using it a lot for libraries that do not come from a package manager.

I usually put those into a vendor directory, maybe you should use that too.

@yani
Copy link
Author

yani commented Sep 7, 2018

I usually put those into a vendor directory, maybe you should use that too.

Hence why I mentioned the package manager, I use the vendor folder as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants