Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding robust settings options #143

Closed
rbenson opened this issue Nov 8, 2018 · 2 comments
Closed

Adding robust settings options #143

rbenson opened this issue Nov 8, 2018 · 2 comments

Comments

@rbenson
Copy link

rbenson commented Nov 8, 2018

I have been playing around with changing my theme at certain times of the day, dark to light. I know you can throw todo.colors.xxx in to customize settings. Some settings allow you to do:

"workbench.colorCustomizations": {
    "settingOne": "xxx",
    "settingTwo": "......",
    "[LightTheme]":{  "settingOne": "yyy"}
    "[ThemeThree]":{  "settingOne": "zzz"}
  }

is there a way to allow this level of customization for todo+?

@fabiospampinato
Copy link
Owner

This isn't possible currently via Todo+ alone, we can't provide good colors for every theme by default (microsoft/vscode#32813) and we can't have a custom editor/tab color (microsoft/vscode#35379).

Although I don't think there's an API for detecting if the current color scheme is dark or light it looks like VSCode supports defining both dark and light colors, and then it will pick the right ones on its own 🤔 I'll add support for this (maybe tomorrow), thanks for the suggestion 👍

If you want to do this right now it would be possible via third party extensions that change your settings. You could have some todo.colors.* settings, then some alt_todo.colors.* settings or something like that, and the extension could toggle between the two. I don't know if any such extension exists but it should be doable.

@fabiospampinato
Copy link
Owner

Implementd in v4.10.0, there are now todo.colors.dark.* and todo.colors.light.* settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants