Add test

flow-typed/flight.js.flow

@@ -0,0 +1,12 @@
+// @flow
+
+declare type Flight = {
+  id: string,
+  flyFrom: string,
+  cityFrom: string,
+  cityTo: string,
+  flyTo: string,
+  price: string,
+  departureDate: string,
+  arrivalDate: string,
+};

src/components/AirportSelector/AirportSelector.js

@@ -9,7 +9,7 @@ import formatAirportResults from "../../services/Airport/airportResponseFormatte
 
 const throttled = throttle((searchTerm) => getAirportsByTerm(searchTerm), 200);
 
-const AirportSelector = ({ inputLabel, onChange, name }) => {
+const AirportSelector = ({ inputLabel, onChange, nameIdentifier }) => {
   const [inputValue, setInputValue] = useState("");
   const [selectedAirport, setSelectedAirport] = useState(null);
 
@@ -29,9 +29,7 @@ const AirportSelector = ({ inputLabel, onChange, name }) => {
       }}
       onChange={(_e, airport) => {
         setSelectedAirport(airport);
-        if (onChange) {
-          onChange(name, airport);
-        }
+        onChange(nameIdentifier, airport);
       }}
       value={selectedAirport}
     />
@@ -41,7 +39,7 @@ const AirportSelector = ({ inputLabel, onChange, name }) => {
 AirportSelector.propTypes = {
   inputLabel: PropTypes.string.isRequired,
   onChange: PropTypes.func.isRequired,
-  name: PropTypes.string.isRequired,
+  nameIdentifier: PropTypes.string.isRequired,
 };
 
 export default AirportSelector;

src/components/AirportSelector/tests/AirPortSelector.test.js

@@ -12,11 +12,17 @@ const server = setupServer(
   )
 );
 
+const props = {
+  inputLabel: "For",
+  nameIdentifier: "airport",
+  onChange: jest.fn(),
+};
+
 const renderComponent = () => {
   const queryClient = new QueryClient();
   const wrapper = (
     <QueryClientProvider client={queryClient}>
-      <AirportSelector inputLabel="For" name="airport" onChange={jest.fn()} />
+      <AirportSelector {...props} />
     </QueryClientProvider>
   );
 
@@ -62,6 +68,11 @@ test("select autocomplete suggestion", async () => {
   userEvent.click(suggestion);
 
   expect(input).toHaveValue("Václav Havel Airport Prague");
+  expect(props.onChange).toBeCalledWith("airport", {
+    code: "PRG",
+    id: "PRG",
+    name: "Václav Havel Airport Prague",
+  });
 });
 
 test("clear autocomplete suggestion", async () => {

src/components/Search/Search.js

@@ -49,7 +49,7 @@ const Search = ({ onSearchSubmitted }) => {
               rules={{ required: true }}
               render={() => (
                 <AirportSelector
-                  name={FORM_FIELDS.ORIGIN}
+                  nameIdentifier={FORM_FIELDS.ORIGIN}
                   inputLabel="From"
                   onChange={setValue}
                 />
@@ -65,7 +65,7 @@ const Search = ({ onSearchSubmitted }) => {
               rules={{ required: true }}
               render={() => (
                 <AirportSelector
-                  name={FORM_FIELDS.DESTINATION}
+                  nameIdentifier={FORM_FIELDS.DESTINATION}
                   inputLabel="To"
                   onChange={setValue}
                 />

src/services/Flight/flightResponseFormatter.js

@@ -12,16 +12,7 @@ const flightResponseFormatter = (flights: {
     dTimeUTC: number,
     aTimeUTC: number,
   }>,
-}): ?Array<{
-  id: string,
-  flyFrom: string,
-  cityFrom: string,
-  cityTo: string,
-  flyTo: string,
-  price: string,
-  departureDate: string,
-  arrivalDate: string,
-}> => {
+}): ?Array<Flight> => {
   if (!flights) {
     return null;
   }