Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labs Embed Map doesn't work on the test version #434

Closed
pral2a opened this issue Sep 12, 2018 · 6 comments
Closed

Labs Embed Map doesn't work on the test version #434

pral2a opened this issue Sep 12, 2018 · 6 comments
Labels

Comments

@pral2a
Copy link
Member

pral2a commented Sep 12, 2018

Expected behaviour

https://www.fablabs.io/labs/embed
https://www.fablabs.io/labs/map

Actual behaviour

https://test.fablabs.io/labs/embed
https://test.fablabs.io/labs/map

How to reproduce?

Open the URL

@openp2pdesign
Copy link
Contributor

Duplicated / related to #422

@openp2pdesign openp2pdesign added this to the After FAB14 milestone Sep 13, 2018
@pral2a pral2a modified the milestones: After FAB14, FAB14 Front-end Sep 13, 2018
@openp2pdesign
Copy link
Contributor

screen shot 2018-09-13 at 16 18 24

@viktorsmari
Copy link
Member

It would also be nice to make sure our tests catch if this fails or not, for the future.

@fbaiodias
Copy link
Contributor

Seems like https://www.fablabs.io/labs/mapdata.json returns {"maps": [...]} and https://test.fablabs.io/labs/mapdata.json returns [...]

fbaiodias added a commit that referenced this issue Oct 2, 2018
@pral2a
Copy link
Member Author

pral2a commented Oct 2, 2018

@fibasile I guess what @fbaiodias found is due to the last changes on the API?

We should keep the legacy endpoint to support embedded maps so if we want to keep the new format (without labs) we should use a different end-point.

I guess the best will be to use the api.fablabs.io for that end-point as it is use by other external map applications and also add versioning on the API paths to avoid issues

fbaiodias added a commit that referenced this issue Oct 3, 2018
@viktorsmari
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants