Skip to content
This repository has been archived by the owner on Nov 13, 2018. It is now read-only.

Should we start removing samples which are not in line with current Fable-arch api? #62

Closed
kunjee17 opened this issue Feb 2, 2017 · 2 comments
Closed

Should we start removing samples which are not in line with current Fable-arch api? #62

kunjee17 opened this issue Feb 2, 2017 · 2 comments

Comments

@kunjee17
Copy link

kunjee17 commented Feb 2, 2017

withNavigation is removed from App.AppApi so sample should be removed or changed? There may be chance that other samples also needed to removed so if that is OK I ll PR them or just list out here.
@MangelMaxime
Copy link
Member

I planned to do a pass on all the samples when the docs sites update is available.
Doing this pass, I will clean the samples, and migrate the sample to use the latest version of Fable-arch and also have a compliant styling using Bulma where it make sense :)

@kunjee17
Copy link
Author

kunjee17 commented Feb 2, 2017

Cool. I'm closing this for now then... Thanks. 👌

@kunjee17 kunjee17 closed this as completed Feb 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kunjee17 @MangelMaxime