Animated view #36
Merged
Animated view #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 12, 2018 10:59
|
Looks good, there should be no problems to merge. TBH, I haven't really used ReactNative so we don't really test things 😅 I'm just hoping that @forki is having a look and making sure everything works fine 😉 |
|
Yeah, I copied the Fable.Helpers.ReactNative and Fable.Import.ReactNative files into my project and tested them from there. I have some adjustments and I will push them tomorrow. I will also use your suggestion for the Object.assign and push that as well. All my changes are related to RN animations. |
|
Hi, @thitemple , do you have something else to push or this can be merged as is? |
|
ok I merged it and upgraded it to the Fable.Core 3 - you can use 2.0.0-beta-013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to create some animations and realized I could not create the Animated components so I added these to the typings.
Please let me know if it is good enough, and any changes needed.
Also, how do you test this locally? When I build it with FAKE there is no usable output, what am I missing. Thanks.