Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gist-based share link #83

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Gist-based share link #83

merged 1 commit into from
Nov 27, 2018

Conversation

Nhowka
Copy link
Contributor

@Nhowka Nhowka commented Nov 27, 2018

With this we can get a shareable link that is friendly in comparison with what we have now. Needs a github token with the gist scope, but it has a link that sends the user to the right place to get one.

May conflict with #48.

@Nhowka Nhowka changed the title Gist integration Gist-based share link Nov 27, 2018
@alfonsogarciacaro
Copy link
Member

This is really nice @Nhowka, thank you! I assume the "old" way to share code is still valid, right? Would it be also possible to share the code from the REPL to the gist?

Anyways, let's merge this and I'll give it a try to see the possibilities. Thanks again! 🥇

@alfonsogarciacaro alfonsogarciacaro merged commit 63c3ee5 into fable-compiler:master Nov 27, 2018
@Nhowka
Copy link
Contributor Author

Nhowka commented Nov 27, 2018

Yes, the old way still works. When you add a github token it will add a Share to gist button that will create a gist based link instead of the old one.

@alfonsogarciacaro
Copy link
Member

Sorry @Nhowka, I was checking other issues and forgot to update the REPL 😅 I did it now together we other improvements so the gist sharing feature is finally online. It's very cool, thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants