added an exception when misusing macro calls (refs twigphp#922)

fabpot · Dec 7, 2012 · 3ca17ac · 3ca17ac
1 parent 496537a
commit 3ca17ac
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/lib/Twig/ExpressionParser.php b/lib/Twig/ExpressionParser.php
@@ -393,6 +393,10 @@ public function parseSubscriptExpression($node)
         }
 
         if ($node instanceof Twig_Node_Expression_Name && null !== $alias = $this->parser->getImportedSymbol('template', $node->getAttribute('name'))) {
+            if (!$arg instanceof Twig_Node_Expression_Constant) {
+                throw new Twig_Error_Syntax(sprintf('Dynamic macro names are not supported (called on "%s")', $node->getAttribute('name')), $token->getLine(), $this->parser->getFilename());
+            }
+
             $node = new Twig_Node_Expression_MethodCall($node, 'get'.$arg->getAttribute('value'), $arguments, $lineno);
             $node->setAttribute('safe', true);