minor twigphp#3936 Remove usage of isset before array_key_exists as p…

…erformance is not an issue anymore (fabpot) This PR was merged into the 4.x branch. Discussion ---------- Remove usage of isset before array_key_exists as performance is not an issue anymore Commits ------- c8d6df7 Remove usage of isset before array_key_exists as performance is not an issue anymore
fabpot · Dec 9, 2023 · 7e48b0a · 7e48b0a
2 parents a2eb71c + c8d6df7
commit 7e48b0a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/Node/Expression/NameExpression.php b/src/Node/Expression/NameExpression.php
@@ -60,9 +60,7 @@ public function compile(Compiler $compiler): void
                 ;
             } else {
                 $compiler
-                    ->raw('(isset($context[')
-                    ->string($name)
-                    ->raw(']) || array_key_exists(')
+                    ->raw('(array_key_exists(')
                     ->string($name)
                     ->raw(', $context) ? $context[')
                     ->string($name)

diff --git a/tests/Node/Expression/NameTest.php b/tests/Node/Expression/NameTest.php
@@ -34,7 +34,7 @@ public function getTests()
         $env = new Environment($this->createMock(LoaderInterface::class), ['strict_variables' => true]);
         $env1 = new Environment($this->createMock(LoaderInterface::class), ['strict_variables' => false]);
 
-        $output = '(isset($context["foo"]) || array_key_exists("foo", $context) ? $context["foo"] : throw new RuntimeError(\'Variable "foo" does not exist.\', 1, $this->source))';
+        $output = '(array_key_exists("foo", $context) ? $context["foo"] : throw new RuntimeError(\'Variable "foo" does not exist.\', 1, $this->source))';
 
         return [
             [$node, "// line 1\n".$output, $env],