Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add me #43

Merged
merged 1 commit into from
Jul 9, 2021
Merged

add me #43

merged 1 commit into from
Jul 9, 2021

Conversation

sylv256
Copy link

@sylv256 sylv256 commented Jul 9, 2021

Long have we awaited,
Tehc activated.

@sylv256 sylv256 mentioned this pull request Jul 9, 2021
Open
@sylv256
Copy link
Author

sylv256 commented Jul 9, 2021

im a very popular cringe singularity and everyone is always thinking about me /s

Platymemo
Platymemo suggested changes Jul 9, 2021
View reviewed changes
Copy link

@Platymemo Platymemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good, one slight problem tho.

data/person Show resolved Hide resolved
sylv256
sylv256 commented Jul 9, 2021
View reviewed changes
Copy link
Author

@sylv256 sylv256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am the most based human on planet earth

@sylv256
Copy link
Author

sylv256 commented Jul 9, 2021

I can tell this is a very controversial pr, almost as much as that one heated fluid api pr that kept getting closed

@FoundationGames
Copy link

🚲🏚

IMS212
IMS212 approved these changes Jul 9, 2021
View reviewed changes
Copy link

@IMS212 IMS212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very based

@sylv256
Copy link
Author

sylv256 commented Jul 9, 2021

if this doesn't get merged in 8 hours I'm pinging @everyone

@sylv256
Copy link
Author

sylv256 commented Jul 9, 2021

if this doesn't get merged in 8 hours I'm pinging @everyone

why is someone's username "everyone"

valoeghese
valoeghese approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@valoeghese valoeghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine tbh

williambl
williambl approved these changes Jul 9, 2021
View reviewed changes
Copy link

@williambl williambl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how this was missing for so long

Su5eD
Su5eD approved these changes Jul 9, 2021
View reviewed changes
Copy link

@Su5eD Su5eD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no option to deny, I can only approve :(

@frqnny frqnny merged commit 3e39d51 into fabric-community:master Jul 9, 2021
@sylv256 sylv256 deleted the patch-1 branch July 10, 2021 00:33
lucsoft
lucsoft reviewed Jul 13, 2021
View reviewed changes
Copy link

@lucsoft lucsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but i think there is a typo you mean TehcJS right?

@valoeghese
Copy link
Member

he is known as Tehc on discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucsoft lucsoft lucsoft left review comments

@Platymemo Platymemo Platymemo requested changes

@williambl williambl williambl approved these changes

@IMS212 IMS212 IMS212 approved these changes

@FoundationGames FoundationGames FoundationGames approved these changes

@valoeghese valoeghese valoeghese approved these changes

@Su5eD Su5eD Su5eD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@sylv256 @FoundationGames @valoeghese @williambl @lucsoft @IMS212 @Su5eD @Platymemo @frqnny