Added checkmark icon for checkbox controls #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now more in line with our existing icon set.
|
|
|
I forgot that you have to add the code to the list o.O The code should be \e81e which is the hexadecimal representation of the unicode value 59422 which you can find in the config.json or on the fontello page. https://github.com/wholesale-design-system/scss/blob/master/components/base/_icons.scss#L7 |
Also sorted the list of variable names
|
@fragsalat fixed |
fragsalat
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now more in line with our existing icon set.
Hex code: 0xE81E
Class name: checkmark-checkbox
Resolves #5
@fragsalat Please approve