Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Card): fix toggle-in-card navigation #165

Merged
merged 9 commits into from
Nov 9, 2022
Merged

fix(Card): fix toggle-in-card navigation #165

merged 9 commits into from
Nov 9, 2022

Commits on Nov 7, 2022

  1. fix(css): point at version 1 of fabric-ds/css to handle focus-ring cl… 

    …asses

Use the latest alias of fabric-ds/css package in the test, documentation and storybook environment
    @BalbinaK
    BalbinaK committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    7ec94f9 View commit details
    Browse the repository at this point in the history

  2. fix: handle onClick in Clickable instead of Card if ToggleItem is ren… 

    …dered

If Card renders a Clickable radio toggle, and has tabIndex (onClick prop), it breaks
arrow-navigation between other Toggle radio Cards. In order to fix it, the onClick is moved to the
Clickable component and name prop is provided to Clickable radios of the same group.
    @BalbinaK
    BalbinaK committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    bfcedef View commit details
    Browse the repository at this point in the history

  3. refactor(card): refactor non-flat card style

    @BalbinaK
    BalbinaK committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    0714dd8 View commit details
    Browse the repository at this point in the history

  4. fix(clickable): add focus-ring and focus-ring-inset classes to Toggle… 

    …Item

Display visual feedback on ToggleItem focus
    @BalbinaK
    BalbinaK committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    a5e561e View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. feat(card): log deprecation warning if Card receives onClick prop 

    Click events should be handled by Clickable component, not Card. Before implementing a breaking
change in Card, a deprecation warning is logged if Card receives an onClick prop
    @BalbinaK
    BalbinaK committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    bcf7036 View commit details
    Browse the repository at this point in the history

  2. docs(card): use Clickable instead of Card to pass onClick handler in … 

    …docs examples
    @BalbinaK
    BalbinaK committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    4e640ca View commit details
    Browse the repository at this point in the history

  3. test: update tests with the onClick prop changes

    @BalbinaK
    BalbinaK committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    b70a88f View commit details
    Browse the repository at this point in the history

  4. refactor(dead-toggle): rename 'name' prop in DeadToggle to avoid conf… 

    …usion
    @BalbinaK
    BalbinaK committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    bb9ff0b View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Merge remote-tracking branch 'origin/next' into 113-fix-toggle-in-car… 

    …d-navigation
    @BalbinaK
    BalbinaK committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    5e2a40d View commit details
    Browse the repository at this point in the history