Dependent tasks are now executed per host. #1894
Conversation
The run() and sudo() methods on a Connection give the expectation that the command will be run on the target host(s). However if a task is specified as a pre or post dependency then the command is run on the machine where the fab command was run. This PR modifies the calls in the Executor.expand_calls() method to pass the value of allow_hosts to any dependent tasks. The result is that instead of the dependent tasks being executed only once on source machine they are excuted on each target host.
|
@StuartMacKay thanks for this fix, the referenced issues are still open as of fabric v3. would you want to change the base branch to I'm not a maintainer, just hoping that this can still be merged. |
|
Hi, there is no fabric v3, that (fabric3) was a fork which is no longer maintained.
Please use the latest fabric v2.
Cheers,
David
|
|
@davidjmemmett sorry I'm a bit confused, the latest release of |
|
You're correct - @bitprophet sneaked that out of the door! |
|
@davidjmemmett okay, interesting, thanks -- created #2258 to continue discussion to avoid hijacking this thread in that case, my comment about rebasing on main/v3 no longer applies, and I'd love to see this fix reviewed/merged. let me know if there is anything I can do to push this along, though I'm a new contributor to fabric |
The run() and sudo() methods on a Connection give the expectation that the command will be run on the target host(s). However if a task is specified as a pre or post dependency then the command is run on the machine where the fab command was run.
This PR modifies the calls in the Executor.expand_calls() method to pass the value of allow_hosts to any dependent tasks. The result is that instead of the dependent tasks being executed only once on source machine they are executed on each target host.