New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some PEP 8 love needed #307

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@GaretJax

GaretJax commented Dec 20, 2011

Description

running the pep8 tool shows this:

sa@sub:~/0/python/fabric/fabric$ alias acsn; acsn pep8; pep8 *py
alias acsn='apt-cache search --names-only'
pep8 - Python PEP 8 code style checker
auth.py:10:1: E302 expected 2 blank lines, found 1
colors.py:19:80: E501 line too long (97 characters)
io.py:21:24: E225 missing whitespace around operator
io.py:97:63: E202 whitespace before ')'
main.py:17:23: E261 at least two spaces before inline comment
network.py:25:1: E303 too many blank lines (3)
network.py:55:1: W291 trailing whitespace
network.py:299:5: E301 expected 1 blank line, found 0
sftp.py:275:42: E231 missing whitespace after ','
version.py:95:24: W602 deprecated form of raising exception
sa@sub:~/0/python/fabric/fabric$ 

We should probably update requirements.txt and fabfile.py to include pep8 and have a task for running it automatically on every commit. For more info on pep8: http://pypi.python.org/pypi/pep8


Originally submitted by Markus Gattol (markusgattol) on 2011-03-09 at 04:08am EST


Closed as Done on 2011-04-21 at 08:45pm EDT

@ghost ghost assigned bitprophet Aug 19, 2011

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Aug 19, 2011

Member

Rick Harding (mitechie) posted:


I've pushed a branch in my github fork that pep8's the codebase and the test files:
https://github.com/mitechie/fabric/tree/feature/pep8

There was discussion of getting pep8 checks into the Hudson/Jenkins build server. Since there's not a straight pep8 violations plugin you need to cheat a bit.

Ticket mentioning desire to get a pep8 plugin constructed

Blog post showing perl regex used to format pep8 to match voilations plugin for pylint


on 2011-03-13 at 11:06pm EDT

Member

bitprophet commented Aug 19, 2011

Rick Harding (mitechie) posted:


I've pushed a branch in my github fork that pep8's the codebase and the test files:
https://github.com/mitechie/fabric/tree/feature/pep8

There was discussion of getting pep8 checks into the Hudson/Jenkins build server. Since there's not a straight pep8 violations plugin you need to cheat a bit.

Ticket mentioning desire to get a pep8 plugin constructed

Blog post showing perl regex used to format pep8 to match voilations plugin for pylint


on 2011-03-13 at 11:06pm EDT

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Aug 19, 2011

Member

Morgan Goose (goosemo) posted:


Attached the notes you put in here, rick, onto #87. And pulled in what'd you'd done already to my 1.1 branch. Will need to work out a way to keep this up to snuff.


on 2011-04-05 at 01:41pm EDT

Member

bitprophet commented Aug 19, 2011

Morgan Goose (goosemo) posted:


Attached the notes you put in here, rick, onto #87. And pulled in what'd you'd done already to my 1.1 branch. Will need to work out a way to keep this up to snuff.


on 2011-04-05 at 01:41pm EDT

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Aug 19, 2011

Member

Rick Harding (mitechie) posted:


Applied in changeset commit:422268b3d938ba3eb71fdacae12b209584a5f0dc.


on 2011-04-21 at 08:45pm EDT

Member

bitprophet commented Aug 19, 2011

Rick Harding (mitechie) posted:


Applied in changeset commit:422268b3d938ba3eb71fdacae12b209584a5f0dc.


on 2011-04-21 at 08:45pm EDT

@bitprophet bitprophet closed this Aug 19, 2011

ramonvanalteren pushed a commit to ramonvanalteren/fabric that referenced this pull request Aug 31, 2011

@GaretJax

This comment has been minimized.

Show comment
Hide comment
@GaretJax

GaretJax Dec 20, 2011

Sorry, swapped issue number (want to attach to #370, not 307 :-( )

GaretJax commented Dec 20, 2011

Sorry, swapped issue number (want to attach to #370, not 307 :-( )

richid pushed a commit to richid/fabric that referenced this pull request Aug 1, 2012

Fixes fabric#307 Update code to match Pep8 standards
- I've updated most of the code to match PEP8. There are a few valid exceptions
left behind
- Note, stripping trailing whitespace from "expecting" strings in
test_networks.py will break tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment