Skip to content
This repository

some PEP 8 love needed #307

Closed
wants to merge 2 commits into from

2 participants

Jeff Forcier Jonathan Stoppani
Jeff Forcier
Owner

Description

running the pep8 tool shows this:

sa@sub:~/0/python/fabric/fabric$ alias acsn; acsn pep8; pep8 *py
alias acsn='apt-cache search --names-only'
pep8 - Python PEP 8 code style checker
auth.py:10:1: E302 expected 2 blank lines, found 1
colors.py:19:80: E501 line too long (97 characters)
io.py:21:24: E225 missing whitespace around operator
io.py:97:63: E202 whitespace before ')'
main.py:17:23: E261 at least two spaces before inline comment
network.py:25:1: E303 too many blank lines (3)
network.py:55:1: W291 trailing whitespace
network.py:299:5: E301 expected 1 blank line, found 0
sftp.py:275:42: E231 missing whitespace after ','
version.py:95:24: W602 deprecated form of raising exception
sa@sub:~/0/python/fabric/fabric$ 

We should probably update requirements.txt and fabfile.py to include pep8 and have a task for running it automatically on every commit. For more info on pep8: http://pypi.python.org/pypi/pep8


Originally submitted by Markus Gattol (markusgattol) on 2011-03-09 at 04:08am EST


Closed as Done on 2011-04-21 at 08:45pm EDT

Jeff Forcier
Owner

Morgan Goose (goosemo) posted:


Attached the notes you put in here, rick, onto #87. And pulled in what'd you'd done already to my 1.1 branch. Will need to work out a way to keep this up to snuff.


on 2011-04-05 at 01:41pm EDT

Jeff Forcier
Owner

Rick Harding (mitechie) posted:


Applied in changeset commit:422268b3d938ba3eb71fdacae12b209584a5f0dc.


on 2011-04-21 at 08:45pm EDT

Jeff Forcier
Owner

Rick Harding (mitechie) posted:


I've pushed a branch in my github fork that pep8's the codebase and the test files:
https://github.com/mitechie/fabric/tree/feature/pep8

There was discussion of getting pep8 checks into the Hudson/Jenkins build server. Since there's not a straight pep8 violations plugin you need to cheat a bit.

Ticket mentioning desire to get a pep8 plugin constructed

Blog post showing perl regex used to format pep8 to match voilations plugin for pylint


on 2011-03-13 at 11:06pm EDT

Jeff Forcier bitprophet closed this August 18, 2011
Ramon van Alteren ramonvanalteren referenced this pull request from a commit in ramonvanalteren/fabric April 21, 2011
Jeff Forcier Add changelog entry re #307 33cc7e2
Jonathan Stoppani

Sorry, swapped issue number (want to attach to #370, not 307 :-( )

Rich Schumacher richid referenced this pull request from a commit in richid/fabric March 13, 2011
Rick Harding Fixes #307 Update code to match Pep8 standards
- I've updated most of the code to match PEP8. There are a few valid exceptions
left behind
- Note, stripping trailing whitespace from "expecting" strings in
test_networks.py will break tests
422268b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 2 unique commits by 1 author.

Dec 20, 2011
Jonathan Stoppani Fix put operation to consider remote cwd as set by the context manage…
…r when the remote_path argument is empty.
7056556
Jonathan Stoppani Consider local path as set by lcd context manager when using put with…
… an empty local_path argument.
3e01f5a
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 4 additions and 3 deletions. Show diff stats Hide diff stats

  1. 7  fabric/operations.py
7  fabric/operations.py
@@ -386,7 +386,7 @@ def put(local_path=None, remote_path=None, use_sudo=False,
386 386
         also exhibits the ``.failed`` and ``.succeeded`` attributes.
387 387
     """
388 388
     # Handle empty local path
389  
-    local_path = local_path or os.getcwd()
  389
+    local_path = local_path or env.lcwd or os.getcwd()
390 390
 
391 391
     # Test whether local_path is a path or a file-like object
392 392
     local_is_path = not (hasattr(local_path, 'read') \
@@ -397,8 +397,9 @@ def put(local_path=None, remote_path=None, use_sudo=False,
397 397
     with closing(ftp) as ftp:
398 398
         home = ftp.normalize('.')
399 399
 
400  
-        # Empty remote path implies cwd
401  
-        remote_path = remote_path or home
  400
+        # Empty remote path implies cwd as set by cd context manager
  401
+        # If not set fall back to home directory
  402
+        remote_path = remote_path or env.get('cwd') or home
402 403
 
403 404
         # Expand tildes
404 405
         if remote_path.startswith('~'):
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.