some PEP 8 love needed #307

wants to merge 2 commits into

2 participants

Fabric member


running the pep8 tool shows this:

sa@sub:~/0/python/fabric/fabric$ alias acsn; acsn pep8; pep8 *py
alias acsn='apt-cache search --names-only'
pep8 - Python PEP 8 code style checker E302 expected 2 blank lines, found 1 E501 line too long (97 characters) E225 missing whitespace around operator E202 whitespace before ')' E261 at least two spaces before inline comment E303 too many blank lines (3) W291 trailing whitespace E301 expected 1 blank line, found 0 E231 missing whitespace after ',' W602 deprecated form of raising exception

We should probably update requirements.txt and to include pep8 and have a task for running it automatically on every commit. For more info on pep8:

Originally submitted by Markus Gattol (markusgattol) on 2011-03-09 at 04:08am EST

Closed as Done on 2011-04-21 at 08:45pm EDT

@bitprophet bitprophet was assigned Aug 19, 2011
Fabric member

Rick Harding (mitechie) posted:

I've pushed a branch in my github fork that pep8's the codebase and the test files:

There was discussion of getting pep8 checks into the Hudson/Jenkins build server. Since there's not a straight pep8 violations plugin you need to cheat a bit.

Ticket mentioning desire to get a pep8 plugin constructed

Blog post showing perl regex used to format pep8 to match voilations plugin for pylint

on 2011-03-13 at 11:06pm EDT

Fabric member

Morgan Goose (goosemo) posted:

Attached the notes you put in here, rick, onto #87. And pulled in what'd you'd done already to my 1.1 branch. Will need to work out a way to keep this up to snuff.

on 2011-04-05 at 01:41pm EDT

Fabric member

Rick Harding (mitechie) posted:

Applied in changeset commit:422268b3d938ba3eb71fdacae12b209584a5f0dc.

on 2011-04-21 at 08:45pm EDT

@bitprophet bitprophet closed this Aug 19, 2011
@ramonvanalteren ramonvanalteren pushed a commit to ramonvanalteren/fabric that referenced this pull request Aug 31, 2011
@bitprophet bitprophet Add changelog entry re #307 33cc7e2

Sorry, swapped issue number (want to attach to #370, not 307 :-( )

@richid richid pushed a commit to richid/fabric that referenced this pull request Aug 1, 2012
@mitechie mitechie Fixes #307 Update code to match Pep8 standards
- I've updated most of the code to match PEP8. There are a few valid exceptions
left behind
- Note, stripping trailing whitespace from "expecting" strings in will break tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment