New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with sftp put while having use_sudo together with mode set #917

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@nl5887

nl5887 commented Jun 19, 2013

No description provided.

@bitprophet

This comment has been minimized.

Member

bitprophet commented Jul 7, 2013

I really like this idea, thanks! Should solve a common complaint and I don't see an obvious downside.

Might just be Github but did you submit this using tabs or something? Otherwise the indent level appears to be off.

Also lacking the usual stuff re: changelog (could also use a test in integration/ if you have time, but not 100% critical) - see https://github.com/fabric/fabric/blob/master/CONTRIBUTING.rst :)

If you can fix up the above I'll merge - thanks again.

@nl5887

This comment has been minimized.

Owner

nl5887 commented on 98238b9 Jul 15, 2013

Sample code:
put(StringIO.StringIO(""), 'test.txt', use_sudo=True, mode=0600)

@nl5887

This comment has been minimized.

nl5887 commented Jul 15, 2013

Fixed the issue with indentation, updated changelog and added test in integration/.

@nl5887 nl5887 closed this Jul 15, 2013

@nl5887 nl5887 reopened this Jul 15, 2013

@bitprophet

This comment has been minimized.

Member

bitprophet commented Feb 14, 2014

Back on this, changelog entry did not match rest of the changelog in style (sorry) & the test doesn't work at all for me (did you try it?) but I fixed both of those up & will merge into 1.7.x and 1.8.x soon. Thanks again.

@bitprophet bitprophet closed this Feb 14, 2014

bitprophet added a commit that referenced this pull request Feb 14, 2014

bitprophet added a commit that referenced this pull request Feb 14, 2014

@nl5887

This comment has been minimized.

nl5887 commented Feb 15, 2014

Thx, for fixing. Will take care about it next time. Thought I tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment