Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print abort and warn messages in red/magenta #924

Merged
merged 3 commits into from Jul 7, 2013
Merged

Conversation

@asmeurer
Copy link

@asmeurer asmeurer commented Jul 7, 2013

This makes them much easier to spot, and to notice when your fab failed.

This fixes (the easy part of) #923.

This makes them much easier to spot, and to notice when your fab failed.

This fixes (the easy part of) #923.
@asmeurer asmeurer mentioned this pull request Jul 7, 2013
@asmeurer
Copy link
Author

@asmeurer asmeurer commented Jul 7, 2013

I didn't add any tests for this. Should I?

@asmeurer
Copy link
Author

@asmeurer asmeurer commented Jul 7, 2013

I just realized I didn't color error. Not sure how that should be done.

@asmeurer
Copy link
Author

@asmeurer asmeurer commented Jul 7, 2013

Oh, never mind, it does color error, which apparently just calls abort (I didn't notice because I was on the wrong branch).

bitprophet added a commit that referenced this pull request Jul 7, 2013
@bitprophet bitprophet merged commit f0249ab into fabric:master Jul 7, 2013
1 check passed
1 check passed
@bitprophet
default The Travis CI build passed
Details
@asmeurer
Copy link
Author

@asmeurer asmeurer commented Jul 7, 2013

Thanks for the help!

rlamy pushed a commit to rlamy/sympy that referenced this pull request Nov 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants