Print abort and warn messages in red/magenta #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes them much easier to spot, and to notice when your fab failed. This fixes (the easy part of) fabric#923.
Closed
|
I didn't add any tests for this. Should I? |
|
I just realized I didn't color |
|
Oh, never mind, it does color error, which apparently just calls abort (I didn't notice because I was on the wrong branch). |
|
Thanks for the help! |
rlamy
pushed a commit
to rlamy/sympy
that referenced
this pull request
Nov 3, 2013
This requires my pull request fabric/fabric#924.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes them much easier to spot, and to notice when your fab failed.
This fixes (the easy part of) #923.