Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Add CVE-2018-18240 #1127

Merged
merged 3 commits into from
Feb 5, 2019
Merged

[java] Add CVE-2018-18240 #1127

merged 3 commits into from
Feb 5, 2019

Conversation

msrb
Copy link
Member

@msrb msrb commented Jan 22, 2019

No description provided.

@msrb msrb requested a review from sivaavkd January 29, 2019 06:34
@msrb
Copy link
Member Author

msrb commented Jan 29, 2019

@sivaavkd This one should be super-easy :)

@msrb
Copy link
Member Author

msrb commented Jan 30, 2019

@sivaavkd the package name is wrong here :)

There is a link to GitHub issue which discusses this vulnerability. We can find a link to PR which addresses the vulnerability.

In the PR, you can see a list of files which needed to be touched to mitigate this vulnerability:

CHANGELOG.md
pippo-core/src/main/java/ro/pippo/core/util/WhitelistObjectInputStream.java
pippo/pippo-session-parent/pippo-session/src/main/java/ro/pippo/session/SerializationSessionDataTranscoder.java

We can ignore CHANGELOG.md. So there are two Maven artifacts/packages which were modified by the PR. One residing in pippo-core/ and the second in pippo/pippo-session-parent/pippo-session/ (path leading to src/ directory which then contains actual source code).

We can find pom.xml files in both subdirectories. And from there we can read the package names:

ro.pippo:pippo-core
ro.pippo:pippo-session

@msrb
Copy link
Member Author

msrb commented Jan 30, 2019

@sivaavkd I've updated the YAML, please check 😉

@msrb msrb merged commit 68b672e into master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants