This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
rh-che #703: Removing support of passing 'identity_id' via query parameter #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry parameter Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 58.11% 55.97% -2.15%
==========================================
Files 8 8
Lines 616 586 -30
==========================================
- Hits 358 328 -30
Misses 209 209
Partials 49 49
Continue to review full report at Codecov.
|
nurali-techie
approved these changes
Nov 28, 2018
There was a problem hiding this comment.
@ibuziuk perfect 👍
happy to see that we are removing identity_id stuff :-) Thank You :-)
|
@ibuziuk I see one todo item "Added/updated documentation", anything is remaining or can I merge this PR ?? |
|
@nurali-techie yes, please - go ahead and merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removing support of passing 'identity_id' via query parameter
Motivation
Update to
6.14.2[1] version of che allows to passidentity_idvia Impersonate-Header. Support of passingidentity_idvia query parameter has been discontinued in rh-che [2] and should be removed from oso-proxy[1] eclipse-che/che#12034
[2] redhat-developer/rh-che#1089
More
Additional Notes