User Login using GitHub [13] [5]

[michaelkleinhenz]

Description

As a user, I want to identify myself at the system using my GitHub login.

Functional Acceptance Criteria

1. The user can log in the system by selecting a login operation and is presented with a login screen that accepts his GitHub login information.
2. Upon successful authentication, the user is returned to the view where he selected the login operation.
3. When opening the application and the user has been authenticated before, the user is automatically logged in and continues to the selected area/page/view of the application.
4. UX implementation as defined by the UX team (Workflow).

Note: failed authentication behaviour is omitted due to the authentication handled by GitHub on the tech level. Not (currently) in the scope of this project.
Note: without authentication, an anonymous user can view read-only all public content on the system.

Non-functional Acceptance Criteria

1. The login button/facility is easily reachable from anywhere in the application.
2. The authentication information is retained in a secure way.
3. The user should only need to (re-)authenticate when he has logged out.
4. The application should be able to preserve authentication information between visits.

Discussions

• Visual Styling of the Login Screen (Discussion) fabric8-ui/fabric8-ux#34

Tasks

• As a user I should be able to log on via central Auth provider #20
• Secure Create/Update/Delete WI/WIT REST Endpoints #243
• Improve the test coverage of: User Auth #219
• Expose Auth provider configuration in Core configuration #325
• Configure Core Deployment with GitHub Secrets / Token Keys #326
• Expose User Profile API #327
• On successful auth redirect back to Referer #328
• Login using Git Hub - Use private variable to store the token fabric8-ui/fabric8-planner#122
• Login using Git Hub - Read/Write view management fabric8-ui/fabric8-planner#123
• Add the Login with GitHub feature fabric8-ui/fabric8-planner#189

[kwk]

Good issue!

When the user is opening the main page of the application and has not been authenticated before, he is presented a login screen that accepts his GitHub login information.

I think we wanted to have the page at least partially browse-able without logging in. Don't we @aslakknutsen ?

Upon successful authentication, the user is presented the work item list view.

Shouldn't the user be presented with whatever page he was previously visiting?

[aslakknutsen]

I think we wanted to have the page at least partially browse-able without logging in. Don't we @aslakknutsen ?

Yes we do

Shouldn't the user be presented with whatever page he was previously visiting?

Sounds like a good idea

[nimishamukherjee]

Upon successful authentication, the user is returned to the view where he selected the login operation

Do we have a login screen, like http://demo.almighty.io/#/login?
If yes, then there would be another scenario - user log in from the login page, and is taken to a default landing page.

[nimishamukherjee]

After the user logs in using Git Hub, we can get the fullName and imageUrl from Git Hub (core has a user API in place for this)
Would displaying of fullName be part of this story? If yes, we need to define the UX for this.

[michaelkleinhenz]

@nimishamukherjee I would put the display of the currently logged in user in an extra story, because UX told us the login stuff is already done.

[michaelkleinhenz]

@kwk @aslakknutsen done, updated the story.

[ldimaggi]

When a user logs in, is he/she taken to the login page (http://demo.almighty.io/#/login), or is a login dialog shown?

[michaelkleinhenz]

@ldimaggi no there is no login page by itself, just a login button that starts the GitHub authN process. This would open some kind of authentication dialog with GitHub and possibly just the login screen of GitHub.

[ldimaggi]

Question on:
Note: without authentication, an anonymous user can view read-only all public content on the system.

How is content designated as "public?"

[michaelkleinhenz]

@ldimaggi all content is public if not defined otherwise :-)
But yes, that refers to a concept that we don't have right now.

[AdamJ]

@michaelkleinhenz Here is the workflow for the Log In: https://redhat.invisionapp.com/share/8K8FFFIEC#/screens

[michaelkleinhenz]

Done.