Inconsistency in comment id when creating vs showing

[xcoulon]

There's an inconsistency in https://github.com/almighty/almighty-core/blob/master/design/comments.go: when creating a workitem comment, the returned id is a UUID, whereas when calling /comments/:id, the id is a string:

Payload definition to create a workitem comment:

var comment = a.Type("Comment", func() {
	a.Description(`JSONAPI store for the data of a comment.  See also http://jsonapi.org/format/#document-resource-object`)
	a.Attribute("type", d.String, func() {
		a.Enum("comments")
	})
	a.Attribute("id", d.UUID, "ID of comment", func() {
		a.Example("40bbdd3d-8b5d-4fd6-ac90-7236b669af04")
	})
	...
})

(source

Endpoint definition to show a comment:

a.Action("show", func() {
	a.Routing(
		a.GET("/:id"),
	)
	a.Params(func() {
		a.Param("id", d.String, "id")
	})
	...

(source)

Should we unify the comment ID to have a UUID in both cases ?

[kwk]

I'd say yes. This needs to be unified to be d.UUID.

[xcoulon]

@kwk ok, let me work on a fix for this, then.