Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Redirect /space/collaborators and /login/* and /user(s)/* to Auth #1667

Merged
merged 18 commits into from
Sep 28, 2017

Conversation

alexeykazakov
Copy link
Contributor

@alexeykazakov alexeykazakov commented Sep 26, 2017

  • Redirect POST/DELETE /space/:spaceID/collaborators to Auth. Tested in chrome and 307 redirects work fine with POST/DELETE.
  • Redirect POST /login/refresh to Auth (instead of delegation)
  • Redirect POST /user to Auth
  • Redirect GET/PATCH /users, /users/:id to Auth
  • Redirect GET /search/users to Auth
  • Drop space resources table
  • Drop oauth states table
  • Removed unused code & not relevant tests
  • /login/generate now generate local tokens/users instead of calling KC

It's part of the cleanup phase of fabric8-services/fabric8-auth#79

@fabric8cd
Copy link

@alexeykazakov snapshot fabric8-wit image is available for testing. docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1667-1

@codecov-io
Copy link

codecov-io commented Sep 26, 2017

Codecov Report

Merging #1667 into master will increase coverage by 3.05%.
The diff coverage is 29.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
+ Coverage   53.92%   56.97%   +3.05%     
==========================================
  Files         128      124       -4     
  Lines       16386    14360    -2026     
==========================================
- Hits         8836     8182     -654     
+ Misses       6866     5554    -1312     
+ Partials      684      624      -60
Impacted Files Coverage Δ
design/auth.go 0% <ø> (ø) ⬆️
auth/authz.go 0% <ø> (ø) ⬆️
main.go 0% <0%> (ø) ⬆️
login/service.go 10.43% <0%> (+1.91%) ⬆️
auth/resource.go 0% <0%> (ø) ⬆️
controller/search.go 62.74% <0%> (-7.93%) ⬇️
token/token.go 42.75% <0%> (-4.08%) ⬇️
controller/user.go 0% <0%> (ø) ⬆️
migration/migration.go 75.89% <100%> (+0.09%) ⬆️
configuration/configuration.go 72.51% <100%> (-0.42%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4a074...f145dcd. Read the comment docs.

@sbose78
Copy link
Member

sbose78 commented Sep 27, 2017

We'll merge this only after the UI PR is merged, right?

@alexeykazakov
Copy link
Contributor Author

We'll merge this only after the UI PR is merged, right?

No, we don't have to wait for the UI. All redirects (even for POST/Patch/Delete) work fine. I didn't notice any issues with that while testing local UI. But we have to merge fabric8-services/fabric8-auth#119 first (to avoid cycle calls).

@fabric8cd
Copy link

@alexeykazakov snapshot fabric8-wit image is available for testing. docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1667-3

@alexeykazakov
Copy link
Contributor Author

Steps to verify:

  • make dev - It will starts all dependencies including auth. Removing the existing db containers before using make dev may be required if they were used independently before pulling this PR.
  • start local UI. Everything should just work. Login, Planner, Collaborator management, etc.

Copy link
Member

@sbose78 sbose78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alexeykazakov alexeykazakov merged commit a2ebc85 into fabric8-services:master Sep 28, 2017
@alexeykazakov alexeykazakov deleted the cleanup-2 branch September 28, 2017 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants