-
Notifications
You must be signed in to change notification settings - Fork 86
Redirect /space/collaborators and /login/* and /user(s)/* to Auth #1667
Redirect /space/collaborators and /login/* and /user(s)/* to Auth #1667
Conversation
@alexeykazakov snapshot fabric8-wit image is available for testing. |
Codecov Report
@@ Coverage Diff @@
## master #1667 +/- ##
==========================================
+ Coverage 53.92% 56.97% +3.05%
==========================================
Files 128 124 -4
Lines 16386 14360 -2026
==========================================
- Hits 8836 8182 -654
+ Misses 6866 5554 -1312
+ Partials 684 624 -60
Continue to review full report at Codecov.
|
We'll merge this only after the UI PR is merged, right? |
No, we don't have to wait for the UI. All redirects (even for POST/Patch/Delete) work fine. I didn't notice any issues with that while testing local UI. But we have to merge fabric8-services/fabric8-auth#119 first (to avoid cycle calls). |
@alexeykazakov snapshot fabric8-wit image is available for testing. |
Steps to verify:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
It's part of the cleanup phase of fabric8-services/fabric8-auth#79