Change test file exclude pattern #2135
Conversation
| @@ -199,7 +199,7 @@ func (s *BenchDbOperations) BenchmarkGormSelectSpaceRaw() { | |||
| &sp.Version, | |||
| &sp.Name, | |||
| &sp.Description, | |||
| &sp.OwnerId) | |||
There was a problem hiding this comment.
This error was always there but since this file was ignored by go build it was never caught.
Codecov Report
@@ Coverage Diff @@
## master #2135 +/- ##
==========================================
+ Coverage 69.23% 69.29% +0.06%
==========================================
Files 163 165 +2
Lines 15185 15238 +53
==========================================
+ Hits 10513 10559 +46
- Misses 3720 3725 +5
- Partials 952 954 +2
Continue to review full report at Codecov.
|
| @@ -118,7 +118,7 @@ DOCKER_COMPOSE_BIN_ALT = $(TMP_PATH)/docker-compose | |||
| DOCKER_COMPOSE_FILE = $(CUR_DIR)/.make/docker-compose.integration-test.yaml | |||
|
|
|||
| # This pattern excludes some folders from the coverage calculation (see grep -v) | |||
| ALL_PKGS_EXCLUDE_PATTERN = 'vendor\|account\/tenant\|app\|tool\/cli\|design\|client\|test' | |||
| ALL_PKGS_EXCLUDE_PATTERN = "vendor\|account\/tenant\|app\'\|tool\/cli\|design\|client\|test" | |||
There was a problem hiding this comment.
Why single quote is escaped here?
Why forward slash is escaped after account? That should be a pipe character, right?
There was a problem hiding this comment.
Why single quote is escaped here?
The regex pattern is grep specific. The \' in this case matches the end of input. Please see https://www.gnu.org/software/findutils/manual/html_node/find_html/grep-regular-expression-syntax.html
Why forward slash is escaped after account? That should be a pipe character, right?
account is not ignored but account/tenant is ignored. I do not know why it is ignored.
There was a problem hiding this comment.
@jarifibrahim Thanks for the clarification!
Fixes #2134
Tests from the following packages will also be executed
github.com/fabric8-services/fabric8-wit/applicationgithub.com/fabric8-services/fabric8-wit/application/repositorygithub.com/fabric8-services/fabric8-wit/gormapplication