This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Updated SHA checksum for dep-darwin-amd64 #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2163 +/- ##
=======================================
Coverage 69.43% 69.43%
=======================================
Files 166 166
Lines 15445 15445
=======================================
Hits 10725 10725
Misses 3749 3749
Partials 971 971Continue to review full report at Codecov.
|
kwk
reviewed
Jul 11, 2018
| @@ -24,6 +24,9 @@ DOCKER_COMPOSE_BIN := $(shell command -v $(DOCKER_COMPOSE_BIN_NAME) 2> /dev/null | |||
| DOCKER_BIN := $(shell command -v $(DOCKER_BIN_NAME) 2> /dev/null) | |||
| MINIMOCK_BIN=$(VENDOR_DIR)/github.com/gojuno/minimock/cmd/minimock/minimock | |||
|
|
|||
| # Define and get the vakue for UNAME_S variable from shell | |||
| UNAME_S := $(shell uname -s) | |||
There was a problem hiding this comment.
What is this used for @rohitkrai03 ?
There was a problem hiding this comment.
@kwk This variable is used to check for the kernel of operating system and then decide which version of dep package to install. On macOS when i tried make build it failed because there was no UNAME_S variable set which is why a version of dep targeted for linux was getting downloaded. I could only run make build succesfully after runningexport UNAME=Darwin
There was a problem hiding this comment.
Ah, I see. Thank you. I was wondering about this because it wasn't explicitly used.
kwk
approved these changes
Jul 11, 2018
There was a problem hiding this comment.
LGTM as long as you keep a reference to where the SHA1 comes from. I found out that it is defined here: https://github.com/golang/dep/releases/download/v0.4.1/dep-darwin-amd64
kwk
added a commit
to openshiftio/saas-openshiftio
that referenced
this pull request
Jul 16, 2018
**commit** fabric8-services/fabric8-wit@cefe36a **Author:** Rohit Kumar Rai <rohitkrai03@gmail.com> **Date:** Wed Jul 11 17:54:40 2018 +0530 Changed SHA checksum for dep-darwin-amd64 and setting UNAME_S variable (fabric8-services/fabric8-wit#2163) - For macOS dep package was updated with a new SHA. This SHA value is checked in `Makefile` with a hardcoded SHA checksum to verify dep package. - Updated the SHA value to new one. - Added initialization of `$(UNAME_S)` variable `UNAME_S=$(shell uname -s)` since it was being used but never set which lead to explicitly exporting the variable from shell. Similar PR for fabric8-auth - fabric8-services/fabric8-auth#549 Note: We can probably look into automating the process where SHA value is fetched dynamically instead of hard coding. **commit** fabric8-services/fabric8-wit@f13e094 **Author:** Elliott Baron <ebaron@redhat.com> **Date:** Wed Jul 11 13:46:08 2018 -0400 Add parameter to Delete Space to skip deleting OpenShift resources (fabric8-services/fabric8-wit#2121) When a user resets their environment, the front-end makes calls to the Delete Space API and Clean Tenant API. It makes these calls asynchronously, and due to both APIs acting on the same resources, I suspect this is the reason we are seeing a variety of errors in openshiftio/openshift.io#3500. Since the Clean Tenant API cleans out the user's entire namespaces, it is not necessary in this case for Delete Space to delete anything from OpenShift. This PR adds an optional parameter skipCluster, to the Delete Space API, which if true, will not attempt to delete any deployments from OpenShift. The front-end could then use this parameter only when resetting the user's environment. An alternative would be for the front-end to synchronize between deleting spaces and calling Clean Tenant, but this would be less efficient. Fixes (partially): openshiftio/openshift.io#3500 **commit** fabric8-services/fabric8-wit@cb85aa7 **Author:** Ibrahim Jarif <jarifibrahim@gmail.com> **Date:** Fri Jul 13 12:57:43 2018 +0530 Refactor search_blackbox_test.go (fabric8-services/fabric8-wit#2148) **commit** eae146f7d3cdf1d6c40588608e60d688aaf6ad83 **Author:** Dhriti Shikhar <dhriti.shikhar.rokz@gmail.com> **Date:** Fri Jul 13 16:55:40 2018 +0530 Increase paging limit (fabric8-services/fabric8-wit#2166) **commit** fabric8-services/fabric8-wit@d198813 **Author:** Baiju Muthukadan <baiju.m.mail@gmail.com> **Date:** Fri Jul 13 17:46:12 2018 +0530 Revert "List work items part of child iterations (fabric8-services/fabric8-wit#2146)" (fabric8-services/fabric8-wit#2168) This reverts commit 68996d1555a29a9ef310403403855b47559d5a71. This is required to address #3974 **commit** fabric8-services/fabric8-wit@a4d9061 **Author:** Michael Kleinhenz <kleinhenz@redhat.com> **Date:** Fri Jul 13 16:24:37 2018 +0200 feat(boardview): Board View for WIT. (fabric8-services/fabric8-wit#2111)
aslakknutsen
pushed a commit
to openshiftio/saas-openshiftio
that referenced
this pull request
Jul 17, 2018
**commit** fabric8-services/fabric8-wit@cefe36a **Author:** Rohit Kumar Rai <rohitkrai03@gmail.com> **Date:** Wed Jul 11 17:54:40 2018 +0530 Changed SHA checksum for dep-darwin-amd64 and setting UNAME_S variable (fabric8-services/fabric8-wit#2163) - For macOS dep package was updated with a new SHA. This SHA value is checked in `Makefile` with a hardcoded SHA checksum to verify dep package. - Updated the SHA value to new one. - Added initialization of `$(UNAME_S)` variable `UNAME_S=$(shell uname -s)` since it was being used but never set which lead to explicitly exporting the variable from shell. Similar PR for fabric8-auth - fabric8-services/fabric8-auth#549 Note: We can probably look into automating the process where SHA value is fetched dynamically instead of hard coding. **commit** fabric8-services/fabric8-wit@f13e094 **Author:** Elliott Baron <ebaron@redhat.com> **Date:** Wed Jul 11 13:46:08 2018 -0400 Add parameter to Delete Space to skip deleting OpenShift resources (fabric8-services/fabric8-wit#2121) When a user resets their environment, the front-end makes calls to the Delete Space API and Clean Tenant API. It makes these calls asynchronously, and due to both APIs acting on the same resources, I suspect this is the reason we are seeing a variety of errors in openshiftio/openshift.io#3500. Since the Clean Tenant API cleans out the user's entire namespaces, it is not necessary in this case for Delete Space to delete anything from OpenShift. This PR adds an optional parameter skipCluster, to the Delete Space API, which if true, will not attempt to delete any deployments from OpenShift. The front-end could then use this parameter only when resetting the user's environment. An alternative would be for the front-end to synchronize between deleting spaces and calling Clean Tenant, but this would be less efficient. Fixes (partially): openshiftio/openshift.io#3500 **commit** fabric8-services/fabric8-wit@cb85aa7 **Author:** Ibrahim Jarif <jarifibrahim@gmail.com> **Date:** Fri Jul 13 12:57:43 2018 +0530 Refactor search_blackbox_test.go (fabric8-services/fabric8-wit#2148) **commit** eae146f7d3cdf1d6c40588608e60d688aaf6ad83 **Author:** Dhriti Shikhar <dhriti.shikhar.rokz@gmail.com> **Date:** Fri Jul 13 16:55:40 2018 +0530 Increase paging limit (fabric8-services/fabric8-wit#2166) **commit** fabric8-services/fabric8-wit@d198813 **Author:** Baiju Muthukadan <baiju.m.mail@gmail.com> **Date:** Fri Jul 13 17:46:12 2018 +0530 Revert "List work items part of child iterations (fabric8-services/fabric8-wit#2146)" (fabric8-services/fabric8-wit#2168) This reverts commit 68996d1555a29a9ef310403403855b47559d5a71. This is required to address #3974 **commit** fabric8-services/fabric8-wit@a4d9061 **Author:** Michael Kleinhenz <kleinhenz@redhat.com> **Date:** Fri Jul 13 16:24:37 2018 +0200 feat(boardview): Board View for WIT. (fabric8-services/fabric8-wit#2111)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefilewith a hardcoded SHA checksum to verify dep package.$(UNAME_S)variableUNAME_S=$(shell uname -s)since it was being used but never set which lead to explicitly exporting the variable from shell.Similar PR for fabric8-auth - fabric8-services/fabric8-auth#549
Note: We can probably look into automating the process where SHA value is fetched dynamically instead of hard coding.